Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(sbb-selection-expansion-panel): add visual spec #2895

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

TomMenga
Copy link
Contributor

@TomMenga TomMenga commented Jul 5, 2024

No description provided.

@TomMenga TomMenga changed the title test(sbb-selection-expansion-panel): add visual spec [WIP] test(sbb-selection-expansion-panel): add visual spec Jul 5, 2024
@github-actions github-actions bot added the pr: peer review required A peer review is required for this pull request label Jul 5, 2024
Copy link
Contributor

@MarioCastigliano MarioCastigliano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, maybe I would try to optimize the number of screenshots since for all the cases where the panel is closed the visual tests on the radio-button/checkbox would practically overlap

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Jul 5, 2024
Copy link
Contributor

@DavideMininni-Fincons DavideMininni-Fincons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@jeripeierSBB jeripeierSBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomMenga
Copy link
Contributor Author

TomMenga commented Jul 8, 2024

https://lyne-components-visual-regression-diff-pr2895.app.sbb.ch/compare/sbb-selection-expansion-panel/checkbox_group_with_error

I was already investigating it and I'd say it's a component problem. This is due to the different "dom structure" between the radio and the checkbox.
Since the fix might impact several components, I'd like a baseline to compare to. So I'm going to merge this and open a new one for the fix

@TomMenga TomMenga merged commit 83ede30 into main Jul 8, 2024
37 of 38 checks passed
@TomMenga TomMenga deleted the visual-spec/selection-panel branch July 8, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants